C: Battery Discharge Rate - Revision history

DragonFlightDesign at 20:22, 15 May 2025

2025-05-15T20:22:16Z

← Older revision		Revision as of 15:22, 15 May 2025
Line 3:		Line 3:
	\| MSFS2020 = unknown		\| MSFS2020 = unknown
	\| FSXI = unknown		\| FSXI = unknown
			\| P3D6 = true
	\| P3D5 = true		\| P3D5 = true
	\| P3D4 = true		\| P3D4 = true

DragonFlightDesign at 20:20, 15 May 2025

2025-05-15T20:20:42Z

← Older revision		Revision as of 15:20, 15 May 2025
Line 19:		Line 19:

	}}		}}
	Updated 30/04/~~2023~~ to ~~use a percentage charge/drain rate per hour as I found an~~ edge case ~~that would cause failure if a specific voltage charge/drain was used.~~		Updated 16/05/2025 to fix another edge-case bug :-{

	//----------------------		//----------------------
Line 38:		Line 38:

	// *******************************************************		// *******************************************************
	// ~~This is called~~ from the CLIENT_1SEC event.		// Called from the CLIENT_1SEC event.
	// Set the battery voltage to avoid a long-standing bug with a sub-twenty minute drain time		// Set the battery voltage to avoid a long-standing bug with a sub-twenty minute drain time
	// Setting charge_discharge_rate to one hundred percent prevents any battery drain at all		// Setting charge_discharge_rate to one hundred percent prevents any battery drain at all
	// Setting charge_discharge_rate to zero will discharge at the default rate		// Setting charge_discharge_rate to zero will discharge at the default rate
	// Setting between ~~one~~ and 99 will charge/discharge at that percentage per hour		// Setting between zero and 99 will charge/discharge at that percentage per hour
	// *******************************************************		// *******************************************************
	void sc_battery_charger(double charge_discharge_rate, double current_volts, double target_volts)		void sc_battery_charger(double charge_discharge_rate, double current_volts, double target_volts)
	{		{
	double volts_out = 0;		double volts_out = 0;
	double rate = 0;		double rate = 0;

	// ~~Rate setting~~		// Sanity checks
	if (charge_discharge_rate >= 100.0)volts_out = target_volts; // No discharge		if (charge_discharge_rate >= 100.0)
	else if (charge_discharge_rate)		{
	{		volts_out = target_volts; // No discharge
	rate = charge_discharge_rate / 3600; // 3600 = 1 hour		}
	//Add the charge to the current voltage (negative for discharge)		else if(charge_discharge_rate == 0.0)
	volts_out = current_volts + rate;		{
	// Sanity check		volts_out = current_volts; // No change
	if (volts_out > target_volts) volts_out = target_volts;		}
	}		else if (charge_discharge_rate)
			{
	// Set the voltage on the sim		rate = charge_discharge_rate / 3600; // 3600 = 1 hour
	if (rate)SimConnect_SetDataOnSimObject(hSimConnect, SET_BATTERY_VOLTS, SIMCONNECT_OBJECT_ID_USER, 0, 1, sizeof(volts_out), &volts_out);		// Add or subtract the percentage charge to the current voltage
			// Current volts can be negative for a discharge
	return;		volts_out = current_volts + rate;
	}		// Sanity check
	[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]]		if (volts_out > target_volts) volts_out = target_volts;
			}

			// Set the voltage on the sim
			if (rate)hres = SimConnect_SetDataOnSimObject(hSimConnect, SET_BATTERY_VOLTS, SIMCONNECT_OBJECT_ID_USER, 0, 1, sizeof(volts_out), &volts_out);

			return;
			}[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]]

BASys: Added INFOBOX Applicable-FSVersion. Corrected CATEGORY to appropriate version(s)

2024-05-25T19:31:23Z

Added INFOBOX Applicable-FSVersion. Corrected CATEGORY to appropriate version(s)

@@ Line 1: / Line 1: @@
 Updated 30/04/2023 to use a percentage charge/drain rate per hour as I found an edge case that would cause failure if a specific voltage charge/drain was used.
@@ Line 45: / Line 65: @@
     return;
+  }
-[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]] [[Category: P3Dv4]] [[Category: P3Dv5]]
+[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]]

Dragonflightdesign at 11:12, 30 April 2023

2023-04-30T11:12:28Z

← Older revision		Revision as of 06:12, 30 April 2023
Line 10:		Line 10:
	{		{
	// Battery charger.		// Battery charger.
	// - dis_charge_rate = charge or drain rate in percentage of system_voltage per hour		// - dis_charge_rate = charge or drain rate in percentage of system_voltage per hour e.g. 2.4 will give a 10% charge, -3.6 will give a 15% drain
	// - battery_voltage should contain the current battery voltage obtained from the sim		// - battery_voltage should contain the current battery voltage obtained from the sim
	// - system_voltage is the battery max value e.g. 24 (volts)		// - system_voltage is the battery max value e.g. 24 (volts)

Dragonflightdesign at 11:10, 30 April 2023

2023-04-30T11:10:28Z

← Older revision		Revision as of 06:10, 30 April 2023
Line 6:		Line 6:

	hr = SimConnect_AddToDataDefinition(hSimConnect, SET_BATTERY_VOLTS, "ELECTRICAL BATTERY VOLTAGE", "Volts", SIMCONNECT_DATATYPE_FLOAT64, 0);		hr = SimConnect_AddToDataDefinition(hSimConnect, SET_BATTERY_VOLTS, "ELECTRICAL BATTERY VOLTAGE", "Volts", SIMCONNECT_DATATYPE_FLOAT64, 0);

			case CLIENT_1SEC:
			{
			// Battery charger.
			// - dis_charge_rate = charge or drain rate in percentage of system_voltage per hour
			// - battery_voltage should contain the current battery voltage obtained from the sim
			// - system_voltage is the battery max value e.g. 24 (volts)
			sc_battery_charger(dis_charge_rate, battery_voltage, system_voltage);
			}
			break;

	// *******************************************************		// *******************************************************

Dragonflightdesign at 11:06, 30 April 2023

2023-04-30T11:06:39Z

← Older revision		Revision as of 06:06, 30 April 2023
Line 1:		Line 1:
	There's a long-standing bug in all versions of FS that causes the battery to discharge in under twenty minutes from the time you start to draw power. This is not related to load. Doug Dawson built an XML add-on that fixes the problem; this is the C equivalent that can be dropped into your code. SET_BATTERY_VOLTS is the enumeration name and I call the function from the ~~CLIENT_4SEC~~ event. By habit I prefix all SimConnect functions with 'sc_'.		Updated 30/04/2023 to use a percentage charge/drain rate per hour as I found an edge case that would cause failure if a specific voltage charge/drain was used.

			//----------------------

			There's a long-standing bug in all versions of FS that causes the battery to discharge in under twenty minutes from the time you start to draw power. This is not related to load. Doug Dawson built an XML add-on that fixes the problem; this is the C equivalent that can be dropped into your code. SET_BATTERY_VOLTS is the enumeration name and I call the function from the CLIENT_1SEC event. By habit I prefix all SimConnect functions with 'sc_'.

	hr = SimConnect_AddToDataDefinition(hSimConnect, SET_BATTERY_VOLTS, "ELECTRICAL BATTERY VOLTAGE", "Volts", SIMCONNECT_DATATYPE_FLOAT64, 0);		hr = SimConnect_AddToDataDefinition(hSimConnect, SET_BATTERY_VOLTS, "ELECTRICAL BATTERY VOLTAGE", "Volts", SIMCONNECT_DATATYPE_FLOAT64, 0);

	// *******************************************************		// *******************************************************
	// Set the battery voltage to avoid a long-standing bug		// This is called from the CLIENT_1SEC event.
	// with a sub-twenty minute drain time		// Set the battery voltage to avoid a long-standing bug with a sub-twenty minute drain time
	// Setting ~~rate~~ to one prevents any battery drain at all		// Setting charge_discharge_rate to one hundred percent prevents any battery drain at all
	// Setting ~~rate~~ to zero will discharge at the default rate		// Setting charge_discharge_rate to zero will discharge at the default rate
	// ~~Any other value~~ between ~~zero~~ and ~~one~~ will ~~add~~/~~subtract from the current volts~~		// Setting between one and 99 will charge/discharge at that percentage per hour
	// *******************************************************		// *******************************************************
	void sc_battery_charger(~~HANDLE hSimConnect,~~ double charge_discharge_rate, double current_volts)		void sc_battery_charger(double charge_discharge_rate, double current_volts, double target_volts)
	{		{
	double volts_out = 0;		double volts_out = 0;
	double rate = 0;		double rate = 0;

	// ~~Sanity check~~		// Rate setting
	if (~~charge_discharge_rate < 0 \|\|~~ charge_discharge_rate > 1.0)~~rate~~ = ~~1.0~~;		if (charge_discharge_rate >= 100.0)volts_out = target_volts; // No discharge
	else rate = charge_discharge_rate;		else if (charge_discharge_rate)
	//Add the charge ~~rate~~		{
	volts_out = current_volts + rate;		rate = charge_discharge_rate / 3600; // 3600 = 1 hour
	// Sanity check		//Add the charge to the current voltage (negative for discharge)
	if (volts_out > ~~24.0~~) volts_out = ~~24.0~~;		volts_out = current_volts + rate;
			// Sanity check
			if (volts_out > target_volts) volts_out = target_volts;
			}

	// Set the voltage on the sim		// Set the voltage on the sim
	SimConnect_SetDataOnSimObject(hSimConnect, SET_BATTERY_VOLTS, SIMCONNECT_OBJECT_ID_USER, 0, 1, sizeof(volts_out), &volts_out);		if (rate)SimConnect_SetDataOnSimObject(hSimConnect, SET_BATTERY_VOLTS, SIMCONNECT_OBJECT_ID_USER, 0, 1, sizeof(volts_out), &volts_out);

	return;		return;
	}		}

	[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]] [[Category: P3Dv4]] [[Category: P3Dv5]]		[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]] [[Category: P3Dv4]] [[Category: P3Dv5]]

Dragonflightdesign: SimConnect code to fix the battery discharge rate bug

2021-04-19T10:23:51Z

SimConnect code to fix the battery discharge rate bug

New page

There's a long-standing bug in all versions of FS that causes the battery to discharge in under twenty minutes from the time you start to draw power. This is not related to load. Doug Dawson built an XML add-on that fixes the problem; this is the C equivalent that can be dropped into your code. SET_BATTERY_VOLTS is the enumeration name and I call the function from the CLIENT_4SEC event. By habit I prefix all SimConnect functions with 'sc_'.

hr = SimConnect_AddToDataDefinition(hSimConnect, SET_BATTERY_VOLTS, "ELECTRICAL BATTERY VOLTAGE", "Volts", SIMCONNECT_DATATYPE_FLOAT64, 0);

// *******************************************************
// Set the battery voltage to avoid a long-standing bug
// with a sub-twenty minute drain time
// Setting rate to one prevents any battery drain at all
// Setting rate to zero will discharge at the default rate
// Any other value between zero and one will add/subtract from the current volts
// *******************************************************
void sc_battery_charger(HANDLE hSimConnect, double charge_discharge_rate, double current_volts)
{
double volts_out = 0;
double rate = 0;

// Sanity check
if (charge_discharge_rate < 0 || charge_discharge_rate > 1.0)rate = 1.0;
else rate = charge_discharge_rate;
//Add the charge rate
volts_out = current_volts + rate;
// Sanity check
if (volts_out > 24.0) volts_out = 24.0;
// Set the voltage on the sim
SimConnect_SetDataOnSimObject(hSimConnect, SET_BATTERY_VOLTS, SIMCONNECT_OBJECT_ID_USER, 0, 1, sizeof(volts_out), &volts_out);

return;
}

[[Category: Aircraft Design]] [[Category: Panel and Gauge Design]] [[Category: P3Dv4]] [[Category: P3Dv5]]